fix(tests): grep -c count duplication on zero matches - #4
Merged
Conversation
- Add 61-test suite covering config, helpers, locks, categories, schema, language - Add GitHub Actions CI with shellcheck, tests, and language enforcement - Rewrite README with architecture diagram, competitor comparison, FAQ - Add examples directory with sample report, scheduling config, multi-repo setup - Add CHANGELOG.md tracking all versions - All code verified English-only Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Fix SC2155: declare and assign separately in worker.sh, coordinator.sh - Fix SC2034: suppress unused-var warnings in config.sh (sourced file) - Fix language check: use byte-level grep to avoid self-detection in tests - Rename unused read vars with _ prefix Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ated it The shellcheck test captured "0\n0" instead of "0" because grep -c outputs the count (0) even on exit code 1, then || echo "0" added a second zero. Changed to || true. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016Sw2Ti3a4Ad8U6JuAyNib1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
grep -coutputs0and exits with code 1 when no matches found|| echo "0"then added a second0, making the variable"0\n0"[[ "0\n0" -eq 0 ]]fails with syntax error, marking all shellcheck tests as FAIL|| trueinstead of|| echo "0"Test plan